Add java-tron-up package#8825
Open
ulissesferreira wants to merge 5 commits into
Open
Conversation
ulissesferreira
temporarily deployed
to
default-branch
GitHub Actions
Inactive
Contributor
Author
|
Code sync follow-up:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
1 similar comment
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82b6ec4. Configure here.
This reverts commit 82b6ec4.
mcmire
reviewed
May 21, 2026
| @@ -0,0 +1,352 @@ | |||
| /* eslint-disable jest/expect-expect, n/no-sync */ | |||
Contributor
There was a problem hiding this comment.
Is there a reason why we aren't using Jest expectations in this file?
| // An object that configures minimum threshold enforcement for coverage results | ||
| coverageThreshold: { | ||
| global: { | ||
| branches: 35, |
Contributor
There was a problem hiding this comment.
Is there a reason why we do not have full test coverage?
| @@ -0,0 +1,18 @@ | |||
| export { | |||
Contributor
There was a problem hiding this comment.
I realize that the Yarn constraints file requires all packages to have an API, but in this case it seems we can make an exception. Perhaps we can remove this file as well as exports, main, and types from package.json and we can modify yarn.config.cjs to exclude this package from various checks that require these fields to be set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
@metamask/java-tron-upto the core monorepo using the generated package structure, then replaces the scaffold with the existing java-tron runtime installer implementation.Ownership follows the runtime tooling/platform pattern and includes Networks, matching the Tron Snap ownership direction.
Changes
packages/java-tron-up.java-tron-upCLI bin fromdist/bin/java-tron-up.mjs.teams.jsonownership.Verification
yarn workspace @metamask/java-tron-up run buildyarn workspace @metamask/java-tron-up run testyarn eslint packages/java-tron-upyarn constraintsyarn lint:misc --check packages/java-tron-up/package.json packages/java-tron-up/README.md packages/java-tron-up/src/index.ts packages/java-tron-up/src/install.ts packages/java-tron-up/src/install.test.ts packages/java-tron-up/src/bin/java-tron-up.ts packages/java-tron-up/jest.config.js .github/CODEOWNERS teams.json README.md tsconfig.json tsconfig.build.jsonyarn readme-content:checkyarn lint:teamsyarn workspace @metamask/java-tron-up run changelog:validateNote
Medium Risk
Adds a new CLI that downloads, verifies, caches, and executes external java-tron and Java runtime artifacts, so failures or supply-chain issues could affect CI/dev workflows. Impact is scoped to the new package and build/reference wiring (no existing runtime behavior changed).
Overview
Adds a new runtime-tooling package,
@metamask/java-tron-up, including ajava-tron-upCLI and exported install APIs to download, SHA-256 verify, cache, and install a platform-specificFullNode.jarplus a matching managed Java runtime, and generate anode_modules/.bin/java-tronwrapper.Wires the package into the monorepo (TypeScript project references,
yarn.lock, README package list) and sets ownership viaCODEOWNERS/teams.json, with initial docs, licenses, typedoc config, and Jest tests covering install/cache/cleanup behavior.Reviewed by Cursor Bugbot for commit 7ad3fd3. Bugbot is set up for automated code reviews on this repo. Configure here.